[L-01] Missing zero-address check in claim function
External function claim#StackedCitadelVester.solis missing zero-address check for the parameter recipient . User could accidentally burn vestingTokens by transfering them to zero-address.
Recommended
Add
require(recipient =! address(0))
[L-02] Lack of event emission at clearCitadelPriceFlag
Function clearCitadelPriceFlag#Funding.sol is missing an event after setting the parameter
citadelpriceFlag to false.
This is important as users will be unaware and can call the public function deposit#Funding.sol that will revert and will spend gas unnecessarily.
Recommended
Add event
[NC-01] Lack of event emission in several functions at SettAccessControl contract
Functions setStrategist, setKeeper and setGovernance lack even emission after those variables are set. Consider adding new events and emit them at the end of every function.
LOW AND NC for Badger Citadel by PeritoFlores
[L-01] Missing zero-address check in
claimfunctionExternal function
claim#StackedCitadelVester.solis missing zero-address check for the parameterrecipient. User could accidentally burn vestingTokens by transfering them to zero-address.Recommended
Add
require(recipient =! address(0))[L-02] Lack of event emission at clearCitadelPriceFlag
Function
clearCitadelPriceFlag#Funding.solis missing an event after setting the parametercitadelpriceFlagto false.This is important as users will be unaware and can call the public function
deposit#Funding.solthat will revert and will spend gas unnecessarily.Recommended
Add event
[NC-01] Lack of event emission in several functions at SettAccessControl contract
Functions
setStrategist,setKeeperandsetGovernancelack even emission after those variables are set. Consider adding new events and emit them at the end of every function.