code-423n4 / 2022-04-dualityfocus-findings

1 stars 0 forks source link

Gas Optimizations #1

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L20 Consider adding empty check for name and symbol.

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L56 Add zero check for amount to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L67 Add zero check for redeemTokens to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L78 Add zero check to redeemAmount to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L88 Add zero check for borrowAmount to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L98 Add zero check to repayAmount to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L111 https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CErc20.sol#L128 Add zero check to repayAmount to save gas fees

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/CToken.sol#L1580 _setInterestRateModel is not called from within the contract. Change the visibility to external.

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L115 enterMarkets is not called from the contract. Change the visiblity to external since function takes memory parameters and public functions tend to save these.

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L696 getAccountLiquidity() function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L743 getHypotheticalAccountLiquidity function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1064 _setPriceOracle function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1082 _setTickOracle function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1105 _setUniV3LpVault function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1390 _setPauseGuardian function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1407 _setMintPaused function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1417 _setBorrowPaused function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1427 _setTransferPaused function is not called from the contract. Consider changing visibility to external

https://github.com/code-423n4/2022-04-dualityfocus/blob/main/contracts/compound_rari_fork/Comptroller.sol#L1436 _setSeizePaused function is not called from the contract. Consider changing visibility to external