code-423n4 / 2022-04-dualityfocus-findings

1 stars 0 forks source link

Missing Slippage Protection #3

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-04-dualityfocus/blob/f21ef7708c9335ee1996142e2581cb8714a525c9/contracts/compound_rari_fork/external/UniV3LpVault.sol

Vulnerability details

Missing slipage protection may lead to losing assets while swapping them. Without slipage protection the swapper is allowed to give much less worth of target tokens than it should in a fair swap. to Missing slippage protection at:

    no slippage protection at _swap at UniV3LpVault.sol at line 626
0xdramaone commented 2 years ago

Duplicate of #42