search

code-423n4 / 2022-04-dualityfocus-findings

1 stars 0 forks source link

QA Report #35

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

QA1:

open todos UniV3LpVault.sol L#142,166

QA2:

Consistently use safeTransfer instead of transfer/transferFrom UniV3LpVault.sol L#366

QA3:

MasterPriceOracle.constructor()._wethAddress (contracts/vault_and_oracles/MasterPriceOracle.sol#40) lacks a zero-check on : - WETH_ADDRESS = _wethAddress (contracts/vault_and_oracles/MasterPriceOracle.sol#52)

MasterPriceOracle.constructor()._admin (contracts/vault_and_oracles/MasterPriceOracle.sol#41) lacks a zero-check on : - admin = _admin (contracts/vault_and_oracles/MasterPriceOracle.sol#53)

MasterPriceOracle.changeAdmin().newAdmin (contracts/vault_and_oracles/MasterPriceOracle.sol#81) lacks a zero-check on : - admin = newAdmin (contracts/vault_and_oracles/MasterPriceOracle.sol#83)