In LPFarming if the owner invokes setContractWhitelisted to false for a previously whitelisted contract, this user will not be able to withdraw or claim the rewards. I don't know if this is intentional or not, but an alternative solution would be to have an actions enum and mapping to the boolean field to make it more manageable.
STRATEGIST_ROLE has a lot of privileges that increase the risk of a rug-pull. A strategist can first invoke setVault, then invoke setStrategy or withdrawAll to transfer the tokens to the vault, or inCaseTokensGetStuck to drain any tokens from the strategies that were deposited by the users. In case one of the strategists' accounts is compromised, they can run away with all the tokens.
In LPFarming if the owner invokes setContractWhitelisted to false for a previously whitelisted contract, this user will not be able to withdraw or claim the rewards. I don't know if this is intentional or not, but an alternative solution would be to have an actions enum and mapping to the boolean field to make it more manageable.
STRATEGIST_ROLE has a lot of privileges that increase the risk of a rug-pull. A strategist can first invoke setVault, then invoke setStrategy or withdrawAll to transfer the tokens to the vault, or inCaseTokensGetStuck to drain any tokens from the strategies that were deposited by the users. In case one of the strategists' accounts is compromised, they can run away with all the tokens.