Open code423n4 opened 2 years ago
The owner configuration function JPEGLock.setLockTime does not emit an event to notify users of a change to the protocol.
JPEGLock.setLockTime
https://github.com/code-423n4/2022-04-jpegd/blob/e72861a9ccb707ced9015166fbded5c97c6991b6/contracts/lock/JPEGLock.sol#L41
An event such as LockTimeChanged(uint newLockTime) could be emitted at the end of the function to provider users with additional transparency over protocol governance.
LockTimeChanged(uint newLockTime)
Missing event
The owner configuration function
JPEGLock.setLockTimedoes not emit an event to notify users of a change to the protocol.https://github.com/code-423n4/2022-04-jpegd/blob/e72861a9ccb707ced9015166fbded5c97c6991b6/contracts/lock/JPEGLock.sol#L41
An event such as
LockTimeChanged(uint newLockTime)could be emitted at the end of the function to provider users with additional transparency over protocol governance.