code-423n4 / 2022-04-jpegd-findings

1 stars 1 forks source link

Gas Optimizations #218

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Gas Optimization #1

Multiple require statements consume less gas than &&. This example is true for most setter functions for rates in this contract.

https://github.com/code-423n4/2022-04-jpegd/blob/e72861a9ccb707ced9015166fbded5c97c6991b6/contracts/vaults/NFTVault.sol#L401-L404

Gas Optimization #2

This struct could benefit slightly from struct packing, e.g. address next to bool

https://github.com/code-423n4/2022-04-jpegd/blob/e72861a9ccb707ced9015166fbded5c97c6991b6/contracts/vaults/NFTVault.sol#L610-L623