search

code-423n4 / 2022-04-mimo-findings

0 stars 0 forks source link

QA Report #162

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

QA

check whether the vault exists before reducing the debt similar to setCollateralBalance() :

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/inception/InceptionVaultsDataProvider.sol#L76

Consider removing the bool to be returned since it isn't being used anywhere :

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/liquidityMining/v2/GenericMinerV2.sol#L248

Unnecessary assignment of default value

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/inception/InceptionVaultsCore.sol#L218