code-423n4 / 2022-04-pooltogether-findings

0 stars 0 forks source link

Gas Optimizations #39

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[2022-04-pooltogether] QA report

tags: `c4`, `2022-04-pooltogether`

SafeApprove is deprecated

affected code: https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L183
proof of concept: as in comment, safeApprove() function is now deprecated
recommended mitigation steps: As per OpenZepplin documentation “whenever possible, use safeIncreaseAllowance and safeDecreaseAllowance instead”.

Unnecessary use of SafeMath

affected code: https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L27
proof of concept: Because you use the solidity 0.8.10, you don't need to use safeMath anymore

PierrickGT commented 2 years ago

SafeApprove is deprecated

Deprecated but perfectly safe to use if allowance is equal to 0, which is the case here.

Unnecessary use of SafeMath

Duplicate of https://github.com/code-423n4/2022-04-pooltogether-findings/issues/11

gititGoro commented 2 years ago

Changing to gas optimization since only the safeMath issue is applicable

JeeberC4 commented 2 years ago

Changing name to better reflect the judging outcome.