search

code-423n4 / 2022-04-xtribe-findings

2 stars 0 forks source link

QA Report #63

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Low

Lack non-zero check in setFlywheelRewards

flywheelRewards can potential set to zero address https://github.com/fei-protocol/flywheel-v2/blob/77bfadf388db25cf5917d39cd9c0ad920f404aad/src/FlywheelCore.sol#L165

Lack non-zero check in setBooster

flywheelBooster can potential set to zero address https://github.com/fei-protocol/flywheel-v2/blob/77bfadf388db25cf5917d39cd9c0ad920f404aad/src/FlywheelCore.sol#L183

Lack non-zero check in constructor of xERC4626

https://github.com/fei-protocol/ERC4626/blob/643cd044fac34bcbf64e1c3790a5126fec0dbec1/src/xERC4626.sol#L38

Non-Critical

Upgrade Solidity Version

Consider to pin Solidity version to latest 0.8.12

Use custom errors

Solidity ^0.8.4 allow the use of custom errors to optimize gas usage. https://blog.soliditylang.org/2021/04/21/custom-errors/