search

code-423n4 / 2022-05-aura-findings

0 stars 1 forks source link

QA Report #355

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Contracts should be deployed with the same compiler version and flags that they have been tested the most with.

https://consensys.net/blog/developers/solidity-best-practices-for-smart-contract-security/

Instances include: https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L2

solution: pragma solidity 0.8.11;

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/Aura.sol#L28

uint256 public constant EMISSIONS_MAX_SUPPLY = 5e25; // 50m

5e25 not egal 50m 5e25 = 5,000,000,000,000,000,000,000,000

  1. comments is wrong --> // 50 septillion (or 50s) or
  2. EMISSIONS_MAX_SUPPLY = 5e7; // 50m

Following function mint() show operations with 5e25, therefore I think it is just a typo in comment.

0xMaharishi commented 2 years ago

5e25 = 5e7 * 1e18 5e7 = 50 000 000 or 50m