GalloDaSballo
commented
2 years ago C4-001: Revert String Size Optimization
6 gas * 27 162
C4-002 : Adding unchecked directive can save gas
20 gas
C4-003 : Check if amount > 0 before token transfer can save gas
Yes but only in "bad path"
C4-004 : There is no need to assign default values to variables
Saves 3 gas
C4-005 : Free gas savings for using solidity 0.8.13+
Glad the warden mentioned what the savings are, but in lack of POC with clear before after, I cannot give any gas saved
C4-006 : Using operator && used more gas
You mention requires but those are ifs, will not award any points
C4-007 : Non-strict inequalities are cheaper than strict ones
In lack of POC I disagree, a strict inequality is just one opcode, a non-strict requires more
C4-008 : Use Custom Errors instead of Revert Strings to save Gas
Same, no POC, no points
C4-010 : Cache array length in for loops can save gas
Saves 3 gas per instance 5 * 3 = 15
C4-011 : State Variables that can be changed to immutable
Saves one SLOAD (in lack of POC), 2.1k
C4-012 : Use calldata instead of memory for function parameters
In lack of POC I won't award points
Total gas saved 2300
I'll penalize this report as it really looks automated
C4-001: Revert String Size Optimization
C4-002 : Adding unchecked directive can save gas
C4-003 : Check if amount > 0 before token transfer can save gas
C4-004 : There is no need to assign default values to variables
C4-005 : Free gas savings for using solidity 0.8.10+
C4-006 : Using operator && used more gas
C4-007 : Non-strict inequalities are cheaper than strict ones
C4-008 : Use Custom Errors instead of Revert Strings to save Gas
C4-009 : Use Shift Right/Left instead of Division/Multiplication if possible
C4-010 : Cache array length in for loops can save gas
C4-011 : State Variables that can be changed to immutable
C4-012 : Use calldata instead of memory for function parameters
C4-001: Revert String Size Optimization
Impact
Shortening revert strings to fit in 32 bytes will decrease deploy time gas and will decrease runtime gas when the revert condition has been met.
Revert strings that are longer than 32 bytes require at least one additional mstore, along with additional overhead for computing memory offset, etc.
Proof of Concept
Revert strings > 32 bytes are here:
Tools Used
Manual Review
Recommended Mitigation Steps
Shorten the revert strings to fit in 32 bytes. That will affect gas optimization.
C4-002 : Adding unchecked directive can save gas
Impact
For the arithmetic operations that will never over/underflow, using the unchecked directive (Solidity v0.8 has default overflow/underflow checks) can save some gas from the unnecessary internal over/underflow checks.
Proof of Concept
Tools Used
None
Recommended Mitigation Steps
Consider applying unchecked arithmetic where overflow/underflow is not possible. Example can be seen from below.
C4-003 : Check if amount > 0 before token transfer can save gas
Impact
Since _amount can be 0. Checking if (_amount != 0) before the transfer can potentially save an external call and the unnecessary gas cost of a 0 token transfer.
Proof of Concept
All Contracts
Tools Used
None
Recommended Mitigation Steps
Consider checking amount != 0.
C4-004 : There is no need to assign default values to variables
Impact - Gas Optimization
Boolean is default initialized to false. There is no need assign false to variable.
Proof of Concept
Tools Used
Code Review
Recommended Mitigation Steps
bool x = false costs more gas than bool x without having any different functionality.
C4-005 : Free gas savings for using solidity 0.8.13+
Impact
Using newer compiler versions and the optimizer gives gas optimizations and additional safety checks are available for free.
Proof of Concept
Solidity 0.8.14 has a useful change which reduced gas costs of external calls which expect a return value: https://blog.soliditylang.org/2021/11/09/solidity-0.8.10-release-announcement/
Solidity 0.8.13 has some improvements too but not well tested.
Code Generator: Skip existence check for external contract if return data is expected. In this case, the ABI decoder will revert if the contract does not exist
All Contracts
Tools Used
None
Recommended Mitigation Steps
Consider to upgrade pragma to at least 0.8.13.
C4-006 : Using operator && used more gas
Impact
Using double require instead of operator && can save more gas.
Proof of Concept
Tools Used
Code Review
Recommended Mitigation Steps
Example
C4-007 : Non-strict inequalities are cheaper than strict ones
Impact
Strict inequalities add a check of non equality which costs around 3 gas.
Proof of Concept
Tools Used
Code Review
Recommended Mitigation Steps
Use >= or <= instead of > and < when possible.
C4-008 : Use Custom Errors instead of Revert Strings to save Gas
Custom errors from Solidity 0.8.4 are cheaper than revert strings (cheaper deployment cost and runtime cost when the revert condition is met)
Source Custom Errors in Solidity:
Starting from Solidity v0.8.4, there is a convenient and gas-efficient way to explain to users why an operation failed through the use of custom errors. Until now, you could already use strings to give more information about failures (e.g., revert("Insufficient funds.");), but they are rather expensive, especially when it comes to deploy cost, and it is difficult to use dynamic information in them.
Custom errors are defined using the error statement, which can be used inside and outside of contracts (including interfaces and libraries).
Instances include:
All require Statements
Tools Used
Code Review
Recommended Mitigation Steps
Recommended to replace revert strings with custom errors.
C4-009 : Use Shift Right/Left instead of Division/Multiplication if possible
Impact
A division/multiplication by any number x being a power of 2 can be calculated by shifting log2(x) to the right/left.
While the DIV opcode uses 5 gas, the SHR opcode only uses 3 gas. Furthermore, Solidity's division operation also includes a division-by-0 prevention which is bypassed using shifting.
Proof of Concept
Contracts
Tools Used
None
Recommended Mitigation Steps
A division/multiplication by any number x being a power of 2 can be calculated by shifting log2(x) to the right/left.
C4-010 : Cache array length in for loops can save gas
Impact
Reading array length at each iteration of the loop takes 6 gas (3 for mload and 3 to place memory_offset) in the stack.
Caching the array length in the stack saves around 3 gas per iteration.
Proof of Concept
Tools Used
None
Recommended Mitigation Steps
Consider to cache array length.
C4-011 : State Variables that can be changed to immutable
Impact
Solidity 0.6.5 introduced immutable as a major feature. It allows setting contract-level variables at construction time which gets stored in code rather than storage.
Consider the following generic example:
In the above example, each call to the function owner() reads from storage, using a sload. After EIP-2929, this costs 2100 gas cold or 100 gas warm. However, the following snippet is more gas efficient:
In the above example, each storage read of the owner state variable is replaced by the instruction push32 value, where value is set during contract construction time. Unlike the last example, this costs only 3 gas.
Proof of Concept
Tools Used
None
Recommended Mitigation Steps
Consider using immutable variable.
C4-012 : Use calldata instead of memory for function parameters
Impact
In some cases, having function arguments in calldata instead of memory is more optimal.
Consider the following generic example:
In the above example, the dynamic array arr has the storage location memory. When the function gets called externally, the array values are kept in calldata and copied to memory during ABI decoding (using the opcode calldataload and mstore). And during the for loop, arr[i] accesses the value in memory using a mload. However, for the above example this is inefficient. Consider the following snippet instead:
In the above snippet, instead of going via memory, the value is directly read from calldata using calldataload. That is, there are no intermediate memory operations that carries this value.
Gas savings: In the former example, the ABI decoding begins with copying value from calldata to memory in a for loop. Each iteration would cost at least 60 gas. In the latter example, this can be completely avoided. This will also reduce the number of instructions and therefore reduces the deploy time cost of the contract.
In short, use calldata instead of memory if the function argument is only read.
Note that in older Solidity versions, changing some function arguments from memory to calldata may cause "unimplemented feature error". This can be avoided by using a newer (0.8.*) Solidity compiler.
Proof of Concept
Tools Used
None
Recommended Mitigation Steps
Some parameters in examples given above are later hashed. It may be beneficial for those parameters to be in memory rather than calldata.