search

code-423n4 / 2022-05-backd-findings

0 stars 0 forks source link

QA Report #146

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

N01 - Typos

protocol/contracts/BkdLocker.sol:173   * @dev This does not invlude the gov. tokens queued for withdrawal. // typo - include
protocol/contracts/tokenomics/FeeBurner.sol:29  event Burned(address targetLpToken, uint256 amountBurned); // Emmited after a successfull burn to target lp token //  typo - successful
protocol/contracts/tokenomics/FeeBurner.sol:84  // Transfering LP tokens back to sender // typo -Transferring

N02 - Open TODO

protocol/contracts/tokenomics/InflationManager.sol:532  //TOOD: See if this is still needed somewhere

N03 - More readable numbers

Numbers like 100000000 could be set 100_000_000 for more readability:

    uint256 private constant _CLIFF_SIZE = 100000 * 1e18; //new cliff every 100,000 tokens 
    uint256 private constant _CLIFF_COUNT = 1000; // 1,000 cliffs
    uint256 private constant _MAX_SUPPLY = 100000000 * 1e18; //100 mil max supply
GalloDaSballo commented 2 years ago

Agree with 1 and 2, personal preference on 3