code-423n4 / 2022-05-backd-findings

0 stars 0 forks source link

QA Report #60

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

L-1 Maybe should have address(0) checks to avoid having to redeploy contracts https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=rewardToken%20%3D%20_rewardToken%3B

L-2 Missing checks for address when assigning values to address state variables https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=rewardToken%20%3D%20newRewardToken%3B

N-1 Multiple addresss mapping can be combined into a single mapping of an address to a struct. https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/BkdLocker.sol#:~:text=mapping(address,)%20public%20totalStashed%3B

N-2 Emit an event in setInflationRecipient() The setInflationRecipient() function is operated only by the governerance and should emit an event when the inflationrecipient is set for the first time or changes. https://github.com/code-423n4/2022-05-backd/blob/main/protocol/contracts/tokenomics/AmmConvexGauge.sol#:~:text=function%20setInflationRecipient(,%7D

GalloDaSballo commented 2 years ago

I think the lack of validation findings have merit, however the Struct commend is not actionable