code-423n4 / 2022-05-backd-findings

0 stars 0 forks source link

QA Report #84

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

The nonReentrant modifier should occur before all other modifiers

This is a best-practice to protect against re-entrancy in other modifiers.

Instances:

contracts/tokenomics/VestedEscrow.sol:89: function fund(FundingAmount[] calldata amounts) external override nonReentrant returns (bool){ contracts/tokenomics/VestedEscrow.sol:138: function claim(address _recipient) public virtual override nonReentrant{ contracts/tokenomics/VestedEscrowRevocable.sol:101: function claim(address _recipient) public override nonReentrant{

Remidiations:

The nonReentrant modifier should occur before all other modifiers

GalloDaSballo commented 2 years ago

Finding is valid