code-423n4 / 2022-05-bunker-findings

1 stars 0 forks source link

QA Report #112

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Title

Missing Event Emit

Impact

_setNftPriceOracle() in Comptroller.sol is missing a critical event emit which prevents the intended data from being observed easily by off-chain interfaces.

PoC

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L764-L774

Tools Used

Manual review

Recommended Mitigation Steps

Add emit for the appropriate event for this function.