code-423n4 / 2022-05-bunker-findings

1 stars 0 forks source link

QA Report #123

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

NC01 some functions declarations exceed recommended maximum line length

From the solidity style guide:

Keeping lines under the PEP 8 recommendation to a maximum of 79 (or 99) characters helps readers easily parse the code.

Example instance

Recommendation make the function declarations over multiple lines

function name(
        type param1,
        type param2,
        type param3
    ) visibilty {
        body
    }

NC02 Many functions are missing documentation

Many functions and complex logic are missing informative documentation and comments.

For example CNft.safeBatchTransferFrom