code-423n4 / 2022-05-bunker-findings

1 stars 0 forks source link

QA Report #87

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[L-01] No event emission for new nft price oracle

Description

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L764

Recommended Mitigation Steps

Consider emitting an event

-----------------------------------------------------------------

[L-02] Missing 0 address check

Description

https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L731

New admin is not checked against 0 value.

Recommended Mitigation Steps

Consider checking if new admin address is not 0

-----------------------------------------------------------------