Open code423n4 opened 2 years ago
https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L764
Consider emitting an event
https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L731
New admin is not checked against 0 value.
Consider checking if new admin address is not 0
[L-01] No event emission for new nft price oracle
Description
https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L764
Recommended Mitigation Steps
Consider emitting an event
-----------------------------------------------------------------
[L-02] Missing 0 address check
Description
https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/Comptroller.sol#L731
New admin is not checked against 0 value.
Recommended Mitigation Steps
Consider checking if new admin address is not 0
-----------------------------------------------------------------