code-423n4 / 2022-05-bunker-findings

1 stars 0 forks source link

QA Report #97

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Low

  1. Title : Warning missing override identifier can make compiler eror

This means if you inherit the ERC1155Enumerable.sol contract into Cnft.sol, you can write your own function and mark it as override since it’s overriding the base totalsupply() & tokensByAccounts() function. If you forget to add the override the compiler will said

TypeError: Overriding function is missing "override" specifier.

and this could be into error to compile the contract

Tool Used

Remix, Manual Review

Recommended Mitigation

add override