code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

QA Report #258

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Use safetransferfrom instead of transfer from on line 199 https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol Reason why if a transfer fails there is a chance you might lose the the token or nft when you transfer. The failure can happen either through gas or just function failure

outdoteth commented 2 years ago

this can be bumped to medium severity: Use safetransferfrom instead of transfer from on line 199: https://github.com/code-423n4/2022-05-cally-findings/issues/38