At Cally.sol, CreateVault() function, it's required that the dutchAuctionStartingStrikeIndex should be less than the strikeOptions.length which has the maximum value of 6765 ether. However, it may be assumed that the contract should be answering the needs even in the worst bearish market conditions where the Eth price is extremely low. The team might consider to increase this highest value to answer the bearish market prices like Eth = 200$.
At Cally.sol, CreateVault() function, there is no address(0) check for token parameter.
block.timestamp is used on many places at the scoped contracts. However, this can be manipulated by malicious miners like the options can be shown as expired before the end of the auction.
Reference
The contracts are not pausable. The team might consider to add a pause() function if any DoS is performed to the website or any unexpected events might occur while the usersare having disadventages of this.
HardlyDifficult
commented
2 years ago
QA (LOW & NON-CRITICAL)
At Cally.sol,
CreateVault()function, it's required that thedutchAuctionStartingStrikeIndexshould be less than thestrikeOptions.lengthwhich has the maximum value of 6765 ether. However, it may be assumed that the contract should be answering the needs even in the worst bearish market conditions where the Eth price is extremely low. The team might consider to increase this highest value to answer the bearish market prices like Eth = 200$.At Cally.sol,
CreateVault()function, there is no address(0) check fortokenparameter.block.timestampis used on many places at the scoped contracts. However, this can be manipulated by malicious miners like the options can be shown as expired before the end of the auction. ReferenceThe contracts are not pausable. The team might consider to add a pause() function if any DoS is performed to the website or any unexpected events might occur while the usersare having disadventages of this.