search

code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

QA Report #286

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

1: Incorrect error message

Line Refrences

Cally.sol#L169

Description

The condition only passes if the reserve strike is less than the starting strike. So if it fails then the reserve strike is too big and the error message should display something like "Reserve strike too large" or "Starting strike too small."

2: No min/max fee rate

Line Refrences

Cally.sol#L119-121

Description

Limits for the fee rate should be set to avoid mistakes when setting the fee. A fee rate that is over 100% could result in the exercise function not being able to execute since the computation on line 289 would result in an underflow and revert.

A constant variable for the max fee rate could be used. The setFee function should check the supplied feeRate against this max fee value.

outdoteth commented 2 years ago

this can be bumped to medium severity: 2: No min/max fee rate: https://github.com/code-423n4/2022-05-cally-findings/issues/48

HardlyDifficult commented 2 years ago

Moved No min/max fee rate to https://github.com/code-423n4/2022-05-cally-findings/issues/319