search

code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

QA Report #291

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

LOW

1. Title: vaultId 1 can't be created

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L188-L189

Currently, vaultId is started by 3. By replacing L188 and 189 can make it start to create the vaultId by number 1 as vaultIndex initialized value.

        vaultId = vaultIndex; //@audit-info: Set vaultId first, then update vaultIndex
    vaultIndex += 2;