QA Report

[code423n4]

Here is 1 finding of the QA report.

---

Cally.sol

[Low-1] Consider adding nonReentrant modifier at createVault, exercise and buyOption

nonReentrant modifier is already used at withdraw function.

It is worth considering adding nonReentrant modifier at createVault, exercise and buyOption functions to be secure, although I cannot think of the attach patterns on these functions though. https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L158-L166

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L258

https://github.com/code-423n4/2022-05-cally/blob/main/contracts/src/Cally.sol#L207

[outdoteth]

adding nonReentrant for no explicit reason adds unnecessary gas