search

code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

No min/max fee rate #319

Closed HardlyDifficult closed 2 years ago

HardlyDifficult commented 2 years ago

From dipp in https://github.com/code-423n4/2022-05-cally-findings/issues/286

No min/max fee rate Line Refrences Cally.sol#L119-121

Description Limits for the fee rate should be set to avoid mistakes when setting the fee. A fee rate that is over 100% could result in the exercise function not being able to execute since the computation on line 289 would result in an underflow and revert.

A constant variable for the max fee rate could be used. The setFee function should check the supplied feeRate against this max fee value.

HardlyDifficult commented 2 years ago

Dupe of https://github.com/code-423n4/2022-05-cally-findings/issues/48

JeeberC4 commented 2 years ago

Issue recreated with script that includes all required data.