code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

Upgraded G -> M from 164 [1654114758938] #330

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #164 as Medium risk. The relevant finding follows:

File:Cally.sol#224 require(msg.value >= premium, "Incorrect ETH amount sent"); Using == operator is 3 gas cheaper than >=. This also keeps people from acedently overpaying when buying an option.

Summary Implementing each of these would reduce the deploymnt cost from 5,431,682 to 5,387,621 and reduces buyOption from 75,765 to 75,013.

HardlyDifficult commented 2 years ago

Dupe of https://github.com/code-423n4/2022-05-cally-findings/issues/84