code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

Upgraded Q -> M from 74 [1654474712630] #336

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #74 as Medium risk. The relevant finding follows:

Use of transferFrom instead of safeTransferFrom Cally.sol#L295

When buyers exercise the transferFrom function is used instead of safeTransferFrom. In the very unlikely event the receiving contract is somehow not aware of incoming ERC721, the token could be locked.

Consider exchanging transferFrom for safeTransferFrom

HardlyDifficult commented 2 years ago

Dupe of https://github.com/code-423n4/2022-05-cally-findings/issues/38