Judge has assessed an item in Issue #74 as Medium risk. The relevant finding follows:
Protocol does not support fee-on-transfer tokens
The tokenIdOrAmount established in createVault prevents buyers from exercise their option because address(this) holds less than tokenIdOrAmount due to the transfer fee.
That is also valid for withdraw.
I recommend making it explicitly to users that such tokens are not supported or preferably only allowing a set of whitelisted ERC20s.
HardlyDifficult
commented
2 years ago
Judge has assessed an item in Issue #74 as Medium risk. The relevant finding follows:
Protocol does not support fee-on-transfer tokens The tokenIdOrAmount established in createVault prevents buyers from exercise their option because address(this) holds less than tokenIdOrAmount due to the transfer fee.
That is also valid for withdraw.
I recommend making it explicitly to users that such tokens are not supported or preferably only allowing a set of whitelisted ERC20s.