Description
Limits for the fee rate should be set to avoid mistakes when setting the fee. A fee rate that is over 100% could result in the exercise function not being able to execute since the computation on line 289 would result in an underflow and revert.
A constant variable for the max fee rate could be used. The setFee function should check the supplied feeRate against this max fee value.
HardlyDifficult
commented
2 years ago
Judge has assessed an item in Issue #286 as Medium risk. The relevant finding follows:
No min/max fee rate Line Refrences Cally.sol#L119-121
Description Limits for the fee rate should be set to avoid mistakes when setting the fee. A fee rate that is over 100% could result in the exercise function not being able to execute since the computation on line 289 would result in an underflow and revert.
A constant variable for the max fee rate could be used. The setFee function should check the supplied feeRate against this max fee value.