code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

Upgraded Q -> M from 98 [1654475216526] #342

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #98 as Medium risk. The relevant finding follows:

Set Limits on setFee() A Malicious owner could set feeRate to = (100 * 1e18) / 100; which would give the entire value of an exercise() transaction to the protocol, create a limit on the fees the owner can set.

https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L119-L121

HardlyDifficult commented 2 years ago

Dupe of #48