Judge has assessed an item in Issue #190 as Medium risk. The relevant finding follows:
[L-02] Fee in Cally.setFee() should be upper-bounded
A malicious owner or owner account compromise can set the fee very high, up to 100%, siphoning all profits from the protocol.
Consider implementing a reasonable upper limit here:
HardlyDifficult
commented
2 years ago
Judge has assessed an item in Issue #190 as Medium risk. The relevant finding follows:
[L-02] Fee in Cally.setFee() should be upper-bounded A malicious owner or owner account compromise can set the fee very high, up to 100%, siphoning all profits from the protocol.
Consider implementing a reasonable upper limit here:
File: Cally.sol 119: function setFee(uint256 feeRate) external onlyOwner { 120: feeRate = feeRate; 121: }