code-423n4 / 2022-05-cally-findings

2 stars 0 forks source link

Upgraded Q -> M from 182 [1655245716777] #346

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #182 as Medium risk. The relevant finding follows:

L-Can send ETH more than buyOption premium required

Link. require(msg.value >= premium) should be require(msg.value == premium) to prevent user send too much eth. Only beneficiary benefit from this. Contract should protect user from these nuance mistakes.

HardlyDifficult commented 2 years ago

Dupe of #84