Gas Optimizations

[code423n4]

Gas

1. Gas
   1. Discrepancy Increment use
   2. change unused public function to external

Discrepancy Increment use

• MerkleLib.verifyProof use i++
• VoterId.createIdentityFor change to allTokens[numIdentities++] = thisToken;
• Current store VoterId mapping is way optimal than standard balances[thisOwner]++ . If change to ++balances[thisOwner], it can save extra 3 gas than current version.

change unused public function to external

Issue copy pasted directly from slither. External function call cost less gas than public function.

• MerkleDropFactory.addMerkleTree(bytes32,bytes32,address,uint256) (MerkleDropFactory.sol#49-62)
• MerkleDropFactory.withdraw(uint256,address,uint256,bytes32[]) (MerkleDropFactory.sol#88-109)
• MerkleIdentity.getPrice(uint256) (MerkleIdentity.sol#140-144)
• MerkleIdentity.isEligible(uint256,address,bytes32[]) (MerkleIdentity.sol#152-155)
• MerkleLib.verifyProof(bytes32,bytes32,bytes32[]) (MerkleLib.sol#17-29)
• MerkleResistor.addMerkleTree(bytes32,bytes32,uint256,uint256,uint256,address,uint256) (MerkleResistor.sol#80-101)
• MerkleVesting.addMerkleRoot(bytes32,bytes32,address,uint256) (MerkleVesting.sol#62-73)
• VoterID.createIdentityFor(address,uint256,string) (VoterID.sol#122-144)
• VoterID.safeTransferFrom(address,address,uint256) (VoterID.sol#226-228)
• VoterID.isApprovedForAll(address,address) (VoterID.sol#270-272)
• VoterID.owner() (VoterID.sol#417-419)

[illuzen]

duplicates