search

code-423n4 / 2022-05-factorydao-findings

1 stars 1 forks source link

QA Report #265

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Doc Issues

Missing critical docs

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L92

The docs should mention that this only supports ERC20 tokens with 18 decimals. Otherwise the contract will malfunction because getRewards assumes it.

Typos

metadataed

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/VoterID.sol#L8

illuzen commented 2 years ago

duplicate