search

code-423n4 / 2022-05-opensea-seaport-findings

1 stars 0 forks source link

QA Report #138

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Non-Critical

Typos

* order toreceive ERC1155 tokens. Also note that //@audit to receive instead of toreceive, comma after Also

proposed change:

* order to receive ERC1155 tokens. Also, note that

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/SeaportInterface.sol#L287

* number of items for offer and consideration along with as set of //@audit a set instead of as set

proposed change:

* number of items for offer and consideration along with a set of

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/SeaportInterface.sol#L248


* order toreceive ERC1155 tokens. Also note that //@audit to receive, comma after also

proposed change:

* order to receive ERC1155 tokens. Also, note that

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/ConsiderationInterface.sol#L288


* @dev Revert with an error when an order or item index are out of range //@audit is not are

proposed change:

* @dev Revert with an error when an order or item index is out of range

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/FulfillmentApplicationErrors.sol#L35

* @dev Revert with an error when a fulfillment is provided as part of an //@audit a not an
*      call to fulfill available orders that does not declare at least one

proposed change:

* @dev Revert with an error when a fulfillment is provided as part of a 
*      call to fulfill available orders that does not declare at least one

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/FulfillmentApplicationErrors.sol#L14-L15


* either the offerrer or the order's zone or approved as valid by the //@audit offerer is mispelled

proposed change:

* either the offerer or the order's zone or approved as valid by the

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/ZoneInteractionErrors.sol#L13

Grammar


* by simulating the fulfillment call prior to execution. Also note //audit comma after also

proposed change:

* by simulating the fulfillment call prior to execution. Also, note

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/ConsiderationInterface.sol#L338


* Also note that all offer and consideration //@audit comma after also

proposed change:

* Also, note that all offer and consideration

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/lib/Consideration.sol#L135


*  before any tokens can be transferred. Also note that //@audit comma after also

proposed change:

*  before any tokens can be transferred. Also, note that

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/lib/Consideration.sol#L68


* by simulating the fulfillment call prior to execution. Also note //@audit comma after also

proposed change:

* by simulating the fulfillment call prior to execution. Also, note

https://github.com/ProjectOpenSea/seaport/blob/e707d4a3e48a33476a6dccf1ede04624e276d283/contracts/interfaces/SeaportInterface.sol#L337

0xleastwood commented 2 years ago

IMO, typos and grammatical errors do not deserve to be awarded unless the specification is clearly mis-leading. This is a low-quality issue, hence, I will mark this as invalid.

GalloDaSballo commented 1 year ago

Typos / descriptions are historically rated NC and bulked together, I believe the report to be worth 1 NC finding