code-423n4 / 2022-05-opensea-seaport-findings

1 stars 0 forks source link

QA Report #147

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

[L-01] Floating pragma and inconsistent compiler version

pragma solidity >=0.8.7;

pragma solidity 0.8.13;

Using a floating pragma (>=) might result in the contract being deployed with a version it was not tested with and might result in bugs that affect the contract system negatively. In addition, older compilers might be susceptible to some bugs. A list of known compiler bugs and their severity can be found here: https://etherscan.io/solcbuginfo

Locking the pragma (deleting the >=) helps to ensure that contracts do not accidentally get deployed using an outdated compiler version or a version it was not tested with. We recommend changing the solidity version pragma to the latest version to enforce the use of an up-to-date compiler.

0xleastwood commented 2 years ago

Not helpful and this shouldn't be included for rewards.

GalloDaSballo commented 1 year ago

Invalid per discussion on #67

GalloDaSballo commented 1 year ago

1 NC