QA Report

[code423n4]

1. Missing zero address check of initialOwner in createConduit of ConduitController.sol

• Consider adding zero address checks while setting initialOwner.

function createConduit(bytes32 conduitKey, address initialOwner)
        external
        override
        returns (address conduit)
    {
       ......
       //recommendation
       if(initialOwner == address(0){
        revert ZeroAddressError();
        .....
     }

• ConduitController.sol#L57

2. Use specific memory offset variables instead of generic offset in inline assembly

In contracts/lib/GettersAndDerivers.sol#L68

While writing assembly, use the specific memory offset variable for specific structs instead of using generic offsets such as OneWords TwoWords. This make the code easy to read/understand and reduces chances of error on change.

  // Current

  // Get the pointer to the offers array.
  let offerArrPtr := mload(add(orderParameters, TwoWords))

  // Recommended Change:

  // Get the pointer to the offers array.
  let offerArrPtr := mload(add(orderParameters, OrderParameters_offer_head_offset))

[GalloDaSballo]

1. Missing zero address check of initialOwner in createConduit of ConduitController.sol

Valid Low per #56

2. Use specific memory offset variables instead of generic offset in inline assembly

Disagree

1L