search

code-423n4 / 2022-05-opensea-seaport-findings

1 stars 0 forks source link

QA Report #194

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

1. Title: Set amount to 1, to minimize error https://github.com/code-423n4/2022-05-opensea-seaport/blob/main/contracts/lib/Executor.sol#L81

we can set this value constantly as 1, there is no need that this value should be dynamically set, since the _transferERC721() will check if the amount value is 1, and we can remove this check to make it cheaper overall

0age commented 2 years ago

using a constant here, and not the actual value, introduces a vulnerability where a single 721 is transferred but multiple items are expected

HardlyDifficult commented 2 years ago

Merging with https://github.com/code-423n4/2022-05-opensea-seaport-findings/issues/190

Reopening as with this there is now 1 valid low.