code-423n4 / 2022-05-opensea-seaport-findings

1 stars 0 forks source link

QA Report #214

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

The implementation is contrary to comments

See here :

https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/lib/FulfillmentApplier.sol#L182

0age agreed that it should be zero and not non-zero

RecipientCount will always be incremented since it's never assigned a value

The variable recipientCount is initialised to zero and never assigned a value, zero will always the lowest of any value.

https://github.com/code-423n4/2022-05-opensea-seaport/blob/9d7ce4d08bf3c3010304a0476a785c70c0e90ae7/reference/lib/ReferenceBasicOrderFulfiller.sol#L644

For its counterpart additionalTips, a value was assigned. Therefore, make the necessary adjustments to the aforementioned. See below :

https://github.com/code-423n4/2022-05-opensea-seaport/blob/main/reference/lib/ReferenceBasicOrderFulfiller.sol#L712-L715

Another example :

https://github.com/code-423n4/2022-05-opensea-seaport/blob/9d7ce4d08bf3c3010304a0476a785c70c0e90ae7/reference/lib/ReferenceGettersAndDerivers.sol#L112

GalloDaSballo commented 2 years ago

The implementation is contrary to comments

Valid NC

 RecipientCount will always be incremented since it's never assigned a value

Valid gas (not for QA)

1 Valid NC

HardlyDifficult commented 2 years ago

The bar for QA reports in this contest is at least 2 valid non-critical findings or at least one valid low risk finding. Per the comments above, this submission is below that bar -- closing as invalid.