search

code-423n4 / 2022-05-opensea-seaport-findings

1 stars 0 forks source link

Gas Optimizations #82

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

make the variable uninitlized variable to save gas becasue the variable is zero without being initlized /contracts/lib/OrderCombiner.sol:181: for (uint256 i = 0; i < totalOrders; ++i) { ./contracts/lib/OrderCombiner.sol:247: for (uint256 j = 0; j < offer.length; ++j) { ./contracts/lib/OrderCombiner.sol:291: for (uint256 j = 0; j < consideration.length; ++j) { ./contracts/lib/OrderCombiner.sol:373: for (uint256 i = 0; i < totalOrders; ++i) { ./contracts/lib/OrderCombiner.sol:473: for (uint256 i = 0; i < totalOfferFulfillments; ++i) { ./contracts/lib/OrderCombiner.sol:498: for (uint256 i = 0; i < totalConsiderationFulfillments; ++i) { ./contracts/lib/OrderCombiner.sol:577: for (uint256 i = 0; i < totalOrders; ++i) { ./contracts/lib/OrderCombiner.sol:598: for (uint256 j = 0; j < consideration.length; ++j) { uint256 totalFilteredExecutions = 0; https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/lib/OrderCombiner.sol#L470

HardlyDifficult commented 2 years ago

I tested this and got mixed results - some functions saved a tiny amount, others got a bit worse. Since this is not a clear win, closing as invalid.