QA Report

[code423n4]

non- critical

ConduitController

• add modifiers for _assertConduitExists(conduit); (used 8 times at the begging of function). https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/conduit/ConduitController.sol#L496

• add modifiers for _assertCallerIsConduitOwner(conduit); (used 3 times at the begging of function). https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/conduit/ConduitController.sol#L480

Assertions

• add modifiers for _assertNonZeroAmount(uint256 amount) (used at the begging of functions). https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/lib/Assertions.sol#L91

OrderFulfiller

• add modifiers for _setReentrancyGuard() and _clearReentrancyGuard() (used at the begging of functions). https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/lib/ReentrancyGuard.sol#L31

  and https://github.com/code-423n4/2022-05-opensea-seaport/blob/4140473b1f85d0df602548ad260b1739ddd734a5/contracts/lib/ReentrancyGuard.sol#L42

[HardlyDifficult]

Modifiers increase the contract size. It's likely intentional to use internal functions instead. They have increased the optimizer runs as high as possible without exceeding the size limit, in order to save end users as much as possible. Since this feedback does not seem to be actionable, closing as invalid.

[GalloDaSballo]

Agree with the judge's take, the refactoring doesn't improve the codebase