code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

QA Report #414

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Title

Upgrade pragma to at least 0.8.4

Impact

Using newer compiler versions and the optimizer gives gas optimizations and additional safety checks are available for free.

The advantages of versions 0.8.* over <0.8.0 are:

Reference

https://docs.soliditylang.org/en/v0.8.14/#:~:text=When%20deploying%20contracts%2C%20you%20should%20use%20the%20latest%20released%20version%20of%20Solidity

POC

https://github.com/code-423n4/2022-05-rubicon/blob/521d50b22b41b1f52ff9a67ea68ed8012c618da9/contracts/rubiconPools/BathToken.sol#L8