search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 416 [1656127747769] #465

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #416 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

RubiconMarket.sol#L298 If feeTo is set to 0x0, most ERC20 implementations (e.g. OpenZeppelin's) will revert on this transfer, making offers unbuyable.

dup of #319