search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 85 [1656128788471] #470

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #85 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

https://github.com/code-423n4/2022-05-rubicon/blob/main/contracts/rubiconPools/BathToken.sol#L260 Function setFeeBPS: _feeBPS should be in between 0 and 100. If it exceeds that then all withdraw will fail

require(_feeBPS>=0 && _feeBPS<=100, "Incorrect fees"); dup of #21