code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 392 [1656129069734] #472

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #392 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

Impact Some tokens return boolean values instead of reverting on failure and should be checked everytime transfer or transferFrom are called. Put the transfer in a require so that a failed transaction that returns false reverts.

dup of #316