search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 234 [1656131418562] #479

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #234 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

Use of transfer might fail in the future transfer() only forward 2300 gas which may break when gas cost change in a future ETH upgrade see: https://consensys.net/diligence/blog/2019/09/stop-using-soliditys-transfer-now/

contracts/RubiconRouter.sol:356: msg.sender.transfer(delta); contracts/RubiconRouter.sol:374: msg.sender.transfer(buy_amt); // Return native ETH contracts/RubiconRouter.sol:434: msg.sender.transfer(delta); contracts/RubiconRouter.sol:451: msg.sender.transfer(pay_amt); contracts/RubiconRouter.sol:491: msg.sender.transfer(withdrawnWETH); contracts/RubiconRouter.sol:548: msg.sender.transfer(fill);

dup of #82