search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> H from 413 [1656340258153] #500

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #413 as High risk. The relevant finding follows:

HickupHH3 commented 2 years ago

L05 - Drain bonus tokens Since bonus tokens distribute each time users withdraw() their shares, there are possible situations when fee amount for withdrawal is less than value of bonus token distributed. It could lead to draining bonus tokens by malicious users which repeatedly deposit-withdraw their shares unlit it's profitably - leaving other shares holders without bonus tokens.

Consider distribution of bonus tokens based on shares holding time.

dup of #109