search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 207 [1656344378079] #504

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #207 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

. Missing checks in adminWriteBathToken Rewriting tokenToBathToken mapping without checks could potentially cause some disruption:

When there are outstanding orders, rewriting bathToken address will prevent strategists from cancelling the orders as tokenToBathToken now points to other contract. If admin mistakenly submits newBathToken which has a different underlying token as overwriteERC20, strategist operations might cause irregularity.

dup of #249