search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 207 [1656344600309] #507

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #207 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago
  1. Unbounded iteration over bonusTokens array If the bonusTokens array grows big enough, the gas cost to execute distributeBonusTokenRewards could be higher than the block limit and the withdraw function is forever disabled.

Recommended Mitigation Keep bonusTokens small by adding a hard limit or add a function to remove bonusTokens.

dup of #249