search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 408 [1656345778095] #512

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #408 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

L01] Use safeTransferFrom/safeTransfer of OZ instead of transferFrom/transfer: It is good to add a require() statement that checks the return value of token transfers or to use something like OpenZeppelin’s safeTransferFrom unless one is sure the given token reverts in case of a failure. Failure to do so will cause silent failures of transfers and affect token accounting in contract.

dup of #316